feat: early return if the l1 fee scalar is zero#3213
Merged
rakita merged 2 commits intobluealloy:mainfrom Dec 8, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #3213 will not alter performanceComparing Summary
|
rakita
approved these changes
Dec 8, 2025
Member
rakita
left a comment
rakita
left a comment
There was a problem hiding this comment.
lgtm, i see logic is not changed
Merged
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Jan 21, 2026
* feat: early return if the l1 fee scalar is zero * update code format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On certain chains (ours included), the L1 fee scalar is set to zero to simplify the fee formula. It would be beneficial to return early during L1 fee calculation when the scalar is zero, thereby avoiding the expensive transaction-size estimation.
Thanks and I’d appreciate your review, and any comments or suggestions are very welcome.